-
-
Notifications
You must be signed in to change notification settings - Fork 661
fix: Make quote blocks isolating #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@nperez0111 maybe we want to make all non-paragraph blocks isolating? This seems to be closer to what Notion does. |
@blocknote/ariakit
@blocknote/code-block
@blocknote/core
@blocknote/mantine
@blocknote/react
@blocknote/server-util
@blocknote/shadcn
@blocknote/xl-ai
@blocknote/xl-docx-exporter
@blocknote/xl-email-exporter
@blocknote/xl-multi-column
@blocknote/xl-odt-exporter
@blocknote/xl-pdf-exporter
commit: |
|
@matthewlipski is isolating what we are looking for here or defining? |
|
I thought defining makes more sense here too, but blocks are already defining by default. I found that isolating also needs to be |
YousefED
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add a test to pasteTestInstances.ts or similar?
Summary
This PR makes quote blocks isolating. That means when pasting content into an empty quote block, it won't overwrite the block type to that of the clipboard content.
Closes #2236
Rationale
There is a scenario where the user wants to paste some text for a quote, so they create a new quote block using the slash menu. They then paste the quoted text into the newly created block, and the type changes to something else. This is not great for UX.
Changes
isolatingflag to quote block.Impact
N/A
Testing
We already have tests for pasting in custom blocks which are isolating.
Screenshots/Video
N/A
Checklist
Additional Notes