Skip to content

Conversation

@VXGP
Copy link

@VXGP VXGP commented Dec 19, 2025

This new feature allows you to prevent individual users from seeing specific check-ins. This can be customized for each check-in individually. Users added to a check-in via this feature's menu will not be able to see that check-in on the user's "En Route," "Dashboard," or "Profile" pages.

see #4242

@VXGP
Copy link
Author

VXGP commented Dec 20, 2025

Ich sehe, dass der Test unter anderem wegen der Datenbank fehlschlägt. Bei meinem lokalen Test hat allerdings alles funktioniert. Wie ist dieses Problem zu lösen? MfG.

@MrKrisKrisu
Copy link
Member

Did you push all the files? At least one file is missing, e.g., the migration.

@MrKrisKrisu MrKrisKrisu changed the title Sichtbarkeit von Check-ins für einzelne Nutzer individuell verbergen ✨ Hide visibility of check-ins for individual users Dec 20, 2025
@VXGP
Copy link
Author

VXGP commented Dec 20, 2025

e.g., the migration.

Possibly I forgot it! I will look for the missing files as soon as I am back home. :)

@VXGP
Copy link
Author

VXGP commented Dec 21, 2025

All files should now be uploaded. @MrKrisKrisu

@VXGP
Copy link
Author

VXGP commented Dec 21, 2025

I see that a check is still failing, which is strange since everything starts normally in my local instance. What can I do? @MrKrisKrisu
Screenshot 2025-12-21 203756

@VXGP
Copy link
Author

VXGP commented Dec 21, 2025

I've added the last missing file that I have forgotten, sorry!

@VXGP
Copy link
Author

VXGP commented Dec 21, 2025

I think everything should be okay now. @MrKrisKrisu :)

@VXGP
Copy link
Author

VXGP commented Dec 23, 2025

With the last commits I fixed all "quality standard" issues. @MrKrisKrisu

@MrKrisKrisu
Copy link
Member

With the last commits I fixed all "quality standard" issues. @MrKrisKrisu

Unfortunately, I won't be able to review this PR over the holidays. Perhaps someone else here has time, or you will need to wait until next year.

@VXGP
Copy link
Author

VXGP commented Dec 23, 2025

I won't be able to review this PR over the holidays

All good, I have no problem waiting. I wish you happy christmas days. ^^

@MrKrisKrisu
Copy link
Member

Just dropping some screenshots of the current state here:

image image

@MrKrisKrisu
Copy link
Member

This is explicitly not a review yet, I just skimmed through it, but here are a few comments:

  1. In my opinion the UI is a bit toooo overloaded with this big component at the bottom. Even before, I thought it was chaotic, but now even more so. It takes up too much space.

  2. Did you test your PR before requesting a review? The feature don't work for me at some points.
    -> for example: The model structure doesn't match the migration, so we cannot save to the table of hidden users. The Model try to save an uuid (which is good!) and the migration creates an id with unsigned big integer.

@VXGP
Copy link
Author

VXGP commented Dec 26, 2025

Thank you for informing me about the UUID/ID issue, I will fix it as soon as possible. Of course I test the PR before submit it, but on my local machine the testing possibilities are slightly limited.

I will try to make the UI more minimalistic and to integrate it better in the empty space.

@VXGP VXGP marked this pull request as draft December 26, 2025 22:18
@VXGP VXGP marked this pull request as ready for review December 28, 2025 20:40
@VXGP
Copy link
Author

VXGP commented Dec 28, 2025

Hey @MrKrisKrisu, I think now the PR is ready for review again.

@VXGP
Copy link
Author

VXGP commented Jan 1, 2026

With the last commit I fixed the missing spaces at line 75 in "DashboardController.php". Now all "quality standards" should have been met. @MrKrisKrisu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants