Skip to content

Conversation

@TNorbury
Copy link

_color field inside of the TinyColor object is now updated when setting the alpha or opacity.

Added relevant tests.

Also updated an import inside of an already existing test while I was here.

closes #3

P.S. I also know that stuff is still getting set up, so lmk if ya need me to update my PR to work with lints or CI.

@calvintam236 calvintam236 added the bug Something isn't working label Jun 24, 2021
calvintam236
calvintam236 previously approved these changes Jun 24, 2021
@TNorbury TNorbury changed the title Update underlying color with setting alpha and opacity. Update underlying color with setting alpha and opacity, and re-structure as library. Jun 24, 2021
@JamesMcIntosh
Copy link

Hi @calvintam236, have you been in contact with FooStudio/Ricardo Mendieta about taking over management of the original repository?
Is this repo fork going to be published to pub.dev?

@WieFel
Copy link
Member

WieFel commented Jun 25, 2021

Hi @calvintam236, have you been in contact with FooStudio/Ricardo Mendieta about taking over management of the original repository?
Is this repo fork going to be published to pub.dev?

@JamesMcIntosh we tried to contact them and waited for a while but they don't seem to answer.
We want to publish this on pub.dev, yes! ;)

@TNorbury
Copy link
Author

merged in #5

@calvintam236 calvintam236 marked this pull request as draft June 25, 2021 23:14
@calvintam236 calvintam236 added enhancement New feature or request bug Something isn't working and removed bug Something isn't working enhancement New feature or request labels Jun 25, 2021
@JamesMcIntosh
Copy link

Hi @calvintam236, have you been in contact with FooStudio/Ricardo Mendieta about taking over management of the original repository?
Is this repo fork going to be published to pub.dev?

@JamesMcIntosh we tried to contact them and waited for a while but they don't seem to answer.
We want to publish this on pub.dev, yes! ;)

Thanks Felix, I've sent @mendieta an email at FooStudio and a message on Linked-In too, he's definitely still around as he's committing almost daily to private repositories on GitHub...

@calvintam236 calvintam236 marked this pull request as ready for review July 3, 2021 23:36
@calvintam236
Copy link
Member

@TNorbury @WieFel Since null safety PR is still not yet here, let’s merge this and get the example project up to date as well.

@calvintam236 calvintam236 merged commit e33128c into TinyCommunity:master Jul 4, 2021
@calvintam236 calvintam236 added this to the v2.0.0 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setAlpha and setOpacity have no effect

4 participants