Optimize Stream.create_stream_from_file_obj by using file.readinto() … #12
Conversation
…to copy data straight into the callback-provided output buffer without any kind of allocation.
|
Mind improving your solution with a fallback in case readinto() is not available, using read() instead in that case? I want to have a as bullet-proof solution as possible here, and some custom implementations might not have readinto-support out of the box, since its a fairly new concept as I understand it. |
…le, use read() instead
|
newest commit doesn't build anymore: |
|
Still doesn't build, you're checking hasattr(strm.file, "readinto"), the attribute is called strm._file however. Please test your builds using the provided test suite (there are alot of tests missing still, but i'm doing my best, step by step). |
|
Hi there, as you can see, your latest commit fails with an access violation under Linux, at least with the tests that i've written so far. Can you evaluate if the tests need to be fixed or if there is a race condition that crashes under Linux and needs to be fixed before it can be merged? Thanks! |
2 participants
…to copy data straight into the callback-provided output buffer without any kind of allocation.