-
-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add loved and liked all recommendation catalogs #85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @TimilsinaBimal, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces two significant new recommendation features: 'Based on what you loved' and 'Based on what you liked' catalogs. These additions enhance the user experience by providing more personalized content suggestions derived from a comprehensive analysis of their past interactions. The implementation involves a new dedicated service for these recommendations, alongside a substantial refactoring of the existing catalog generation and management architecture to centralize and streamline the process. The API endpoints and default configurations have been updated to support these new features, and the project version has been incremented. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new recommendation catalogs based on all 'loved' and 'liked' items, which is a great addition. The implementation includes a new AllBasedService and updates to the settings and catalog generation logic. The code is well-structured, but I've found a critical bug that could cause a server error when generating the manifest for users without custom settings. I've also identified a few areas for improvement regarding code duplication, readability, and a potential behavioral change with item padding in catalogs. Please see my detailed comments below.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new recommendation catalogs based on all 'loved' and 'liked' items, supported by a new AllBasedService. The changes also include a valuable refactoring that centralizes catalog generation logic into the DynamicCatalogService, improving the overall code structure. The new feature is well-integrated. My feedback focuses on improving maintainability by replacing magic numbers with constants and removing some redundant code.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
No description provided.