templates: titles and copy changes from rebrand #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements requested changes from https://opendataservices.plan.io/issues/60080#note-4 Changes existed across three files consisting of the "hero" banner and some paragraph copy. In the base template, there existed some stepwise conditional logic which only replaced one word "Quality" or "Submission" depending on a template variable resulting in e.g. "Data Quality Tool" or "Data Submission Tool". The new options are "Data Quality Checker" and "Data Submission Form", so I've moved the word "Data" inside each branch of the conditional as I think having this more readable is more important than saving a few bytes of space. There is only one word shared between the two branches of the conditional, and it'll make it easier to parse and change these in the future if they ever get re-labelled again.
Contributor
Author
|
@R2ZER0 I wasn't sure which branch to merge into. I assume it's |
Pull Request Test Coverage Report for Build 19958043103Details
💛 - Coveralls |
R2ZER0
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements requested changes from https://opendataservices.plan.io/issues/60080#note-4
Changes existed across three files consisting of the "hero" banner and some paragraph copy.
In the base template, there existed some stepwise conditional logic which only replaced one word "Quality" or "Submission" depending on a template variable resulting in e.g. "Data Quality Tool" or "Data Submission Tool".
The new options are "Data Quality Checker" and "Data Submission Form", so I've moved the word "Data" inside each branch of the conditional as I think having this more readable is more important than saving a few bytes of space. There is only one word shared between the two branches of the conditional, and it'll make it easier to parse and change these in the future if they ever get re-labelled again.