Skip to content

bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after loading a custom map #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Caball009 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after loading a custom map #2034

Caball009 wants to merge 2 commits into from

Conversation

@Caball009
Copy link

@Caball009 Caball009 commented Dec 25, 2025 •
edited
Loading

Currently, each TemplateThing gets assigned a unique ID, but the ID is not reset after each map. This can cause mismatches when playing a multiplayer match after having loaded a custom map or custom shellmap that generates TemplateThings.

TODO:

  • Replicate in Generals

@Caball009 Caball009 added Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Stability Concerns stability of the runtime labels Dec 25, 2025
@Caball009 Caball009 marked this pull request as ready for review December 25, 2025 23:50
@Caball009 Caball009 changed the title bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after playing custom maps bugfix(ThingFactory): Reset ThingTemplate ID for each match to avoid mismatches after loading a custom map Dec 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Something is not working right, typically is user facing Major Severity: Minor < Major < Critical < Blocker Stability Concerns stability of the runtime

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mismatch in ThingTemplate ID after playing a map with map.ini with custom objects

1 participant

@Caball009