-
Notifications
You must be signed in to change notification settings - Fork 5
New IC 4.3.5.0 API #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis pull request performs a comprehensive migration from Maven to Gradle, removes command-handling functionality and several packet listener implementations, refactors the platform abstraction layer with new packet event wrappers and providers, and updates configuration and version metadata to 1.1.0. Changes
Sequence DiagramsequenceDiagram
participant Plugin as Plugin
participant PE as PacketEvents API
participant LP as PacketEventsPacketListenerProvider
participant OH as PacketEventsOutMessagePacketHelper
participant PEE as PacketEventsPacketEvent
participant PW as PacketWrapper
rect rgb(200, 220, 255)
note over Plugin,PW: Packet Event Registration (Initialization)
Plugin->>LP: listenToPlayServerUnifiedChatMessage()
LP->>PE: onPacketSend subscription
end
rect rgb(220, 240, 200)
note over Plugin,PW: Packet Send Flow (New System)
PE->>LP: onPacketSend(ProtocolPacketEvent)
activate LP
LP->>OH: getPacketHandlers()
activate OH
OH-->>LP: MessagePacketHandler for packet type
deactivate OH
LP->>PEE: new PacketEventsPacketEvent(event, converter)
activate PEE
LP->>PEE: delegates packet processing
PEE->>PW: getPacket() conversion
deactivate PEE
deactivate LP
end
rect rgb(255, 240, 200)
note over Plugin,PW: Legacy System (Removed)
autonumber off
Plugin--xLP: old PEOutMessagePacket listener
note right of Plugin: Deleted: direct packet<br/>interception & transformation
end
Estimated code review effort🎯 4 (Complex) | ⏱️ ~75 minutes Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (43)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Migrated code in preparation for 4.3.5.0 new protocol platform api.
LOOHP/InteractiveChat@57e8a36
Summary by CodeRabbit
Release Notes
New Features
Bug Fixes
Changes
✏️ Tip: You can customize this high-level summary in your review settings.