Skip to content

fix bug for isBelongFrame status error #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wustMeiming wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix bug for isBelongFrame status error #485

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06c94a1
fix duplicate key in matrix config file
wustMeiming Oct 11, 2019
a869663
Merge pull request #2 from Tencent/dev
wustMeiming May 15, 2020
404d426
fix isBelongFrame status error in dispatchEnd, because is will change…
wustMeiming May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...roid/matrix-trace-canary/src/main/java/com/tencent/matrix/trace/core/UIThreadMonitor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,9 @@ private void doFrameEnd(long token) {
}

private void dispatchEnd() {
final boolean localBelongFrame = isBelongFrame;

if (isBelongFrame) {
if (localBelongFrame) {
doFrameEnd(token);
}

Expand All @@ -260,7 +261,7 @@ private void dispatchEnd() {
synchronized (observers) {
for (LooperObserver observer : observers) {
if (observer.isDispatchBegin()) {
observer.doFrame(AppMethodBeat.getVisibleScene(), token, SystemClock.uptimeMillis(), isBelongFrame ? end - start : 0, queueCost[CALLBACK_INPUT], queueCost[CALLBACK_ANIMATION], queueCost[CALLBACK_TRAVERSAL]);
observer.doFrame(AppMethodBeat.getVisibleScene(), token, SystemClock.uptimeMillis(), localBelongFrame ? end - start : 0, queueCost[CALLBACK_INPUT], queueCost[CALLBACK_ANIMATION], queueCost[CALLBACK_TRAVERSAL]);
}
}
}
Expand All @@ -273,7 +274,7 @@ private void dispatchEnd() {
synchronized (observers) {
for (LooperObserver observer : observers) {
if (observer.isDispatchBegin()) {
observer.dispatchEnd(dispatchTimeMs[0], dispatchTimeMs[2], dispatchTimeMs[1], dispatchTimeMs[3], token, isBelongFrame);
observer.dispatchEnd(dispatchTimeMs[0], dispatchTimeMs[2], dispatchTimeMs[1], dispatchTimeMs[3], token, localBelongFrame);
}
}
}
Expand Down