WIP things to make Microscope Calibration work #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...in particular for `run_iter()` and more components. Test descan error implementation for correctly handling the names, not only indices. Drive-by flake8 fixes
The types work well to make clear what x and y are, and to distinguish pixel vs physical coordinates in code. * Introduce types for single values as opposed to arrays, which correspond well to single rays etc * Make Grid center a single type * Allow floats for pixel coordinates since conversion to discrete values should happen as late as possible to avoid rounding issues * Test for conversion helpers that reduce boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!
Currently fixes to make LiberTEM/Microscope-Calibration#54 work, later probably some additional tests
Based on #5