Skip to content

Cleanup - squid:S1301 - "switch" statements should have at least 3 "c… #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-ezzat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Cleanup - squid:S1301 - "switch" statements should have at least 3 "c… #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Phoenix/src/main/java/com/yalantis/phoenix/PullToRefreshView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,12 @@ public PullToRefreshView(Context context, AttributeSet attrs) {

public void setRefreshStyle(int type) {
setRefreshing(false);
switch (type) {
case STYLE_SUN:
mBaseRefreshView = new SunRefreshView(getContext(), this);
break;
default:
throw new InvalidParameterException("Type does not exist");
if (type != STYLE_SUN) {
throw new InvalidParameterException("Type does not exist");
} else {
mBaseRefreshView = new SunRefreshView(getContext(), this);
}

mRefreshView.setImageDrawable(mBaseRefreshView);
}

Expand Down
7 changes: 2 additions & 5 deletions ...android_pulltorefreshlibrary_collection/PullToRefreshLayoutTellH/PullToRefreshLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,8 @@ public PullToRefreshLayout(Context context, AttributeSet attrs) {

public void setRefreshStyle(int type) {
setRefreshing(false);
switch (type) {
case STYLE_SUN:
break;
default:
throw new InvalidParameterException("Type does not exist");
if (type != STYLE_SUN) {
throw new InvalidParameterException("Type does not exist");
}
}

Expand Down
23 changes: 10 additions & 13 deletions circlerefreshlayout/src/main/java/com/tuesda/walker/circlerefresh/CircleRefreshLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,19 +194,16 @@ public boolean onInterceptTouchEvent(MotionEvent ev) {
if (mIsRefreshing) {
return true;
}
switch (ev.getAction()) {
//记下按下的Y坐标
case MotionEvent.ACTION_DOWN:
mTouchStartY = ev.getY();
mTouchCurY = mTouchStartY;
break;
case MotionEvent.ACTION_MOVE:
float curY = ev.getY();
float dy = curY - mTouchStartY;
//如果是向下滑动并且已经滑动顶部，拦截点击事件
if (dy > 0 && !canChildScrollUp()) {
return true;
}
if (ev.getAction() == MotionEvent.ACTION_DOWN) {
mTouchStartY = ev.getY();
mTouchCurY = mTouchStartY;
} else if (ev.getAction() == MotionEvent.ACTION_MOVE ) {
float curY = ev.getY();
float dy = curY - mTouchStartY;
//如果是向下滑动并且已经滑动顶部，拦截点击事件
if (dy > 0 && !canChildScrollUp()) {
return true;
}
}
return super.onInterceptTouchEvent(ev);
}
Expand Down
21 changes: 9 additions & 12 deletions jellyrefresh/src/main/java/uk/co/imallan/jellyrefresh/PullToRefreshLayout.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,18 +205,15 @@ public boolean onInterceptTouchEvent(MotionEvent e) {
if (isRefreshing) {
return true;
}
switch (e.getAction()) {
case MotionEvent.ACTION_DOWN:
mTouchStartY = e.getY();
mCurrentY = mTouchStartY;
break;
case MotionEvent.ACTION_MOVE:
float currentY = e.getY();
float dy = currentY - mTouchStartY;
if (dy > 0 && !canChildScrollUp()) {
return true;
}
break;
if (e.getAction() == MotionEvent.ACTION_DOWN) {
mTouchStartY = e.getY();
mCurrentY = mTouchStartY;
} else if (e.getAction() == MotionEvent.ACTION_MOVE) {
float currentY = e.getY();
float dy = currentY - mTouchStartY;
if (dy > 0 && !canChildScrollUp()) {
return true;
}
}
return super.onInterceptTouchEvent(e);
}
Expand Down