Skip to content

Conversation

@Bamcane
Copy link
Member

@Bamcane Bamcane commented Jan 4, 2026

This PR changes a lot, in order to support MSYS2.
I wanted to use MSYS2 (mingw-w64) at first, but then I found it didn't support the feature we used in the code:

	// normal with positional arguments
	str_format(aBuf, sizeof(aBuf), "%1$s %2$s", "first", "second");
	EXPECT_STREQ(aBuf, "first second");

	// reverse
	str_format(aBuf, sizeof(aBuf), "%2$s %1$s", "first", "second");
	EXPECT_STREQ(aBuf, "second first");

	// duplicate
	str_format(aBuf, sizeof(aBuf), "%1$s %1$s %2$d %1$s %2$d", "str", 1);
	EXPECT_STREQ(aBuf, "str str 1 str 1");

so I changed to apply ucrt64 instead.
Windows bam support was removed as bam hasn't support MSYS2 yet.
Also it's difficult to support it as it hasn't any docs to read.
Though my name is Bamcane, I still have to remove it.
But I would add it back as it supports MSYS2. :3

This PR changes how the package is built:
it now uses CPack exclusively to package the binaries.
The dynamic libraries for SDL2, FreeType, OpenGL, and OpenSSL are now included in the package.
The workflows now also build on Windows Server 2022 (the windows-latest is Windows Server 2025)

@Bamcane Bamcane requested a review from Hu1night January 4, 2026 15:43
@Bamcane Bamcane force-pushed the pr-msys2 branch 5 times, most recently from 1cad1f1 to edb94ed Compare January 4, 2026 17:04
We will add it back after Bam supports MSYS2.
@Bamcane Bamcane merged commit ece6a37 into TeeworldsArchive:mods Jan 4, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant