Replacement of parametric angles in OpenGraph, PauliFlow and XZCorrections
#410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 85.03% 84.99% -0.04%
==========================================
Files 46 46
Lines 6654 6677 +23
==========================================
+ Hits 5658 5675 +17
- Misses 996 1002 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| """ | ||
| return self.og.measurements[node].to_plane_or_axis() | ||
|
|
||
| def subs( # noqa: PYI019 Annotating with `Self` is not possible since `self` must be of parametric type `Measurement`. |
Collaborator
There was a problem hiding this comment.
Why is self: PauliFlow[Measurement] not enough? I think both PauliFlow and Measurement could be considered final classes.
Contributor
Author
There was a problem hiding this comment.
I had an issue with the return type: if it is PauliFlow[Measurement] the following code is problematic:
alpha = Placeholder("alpha")
value = 0.3
og = OpenGraph(graph=nx.Graph([(0, 1)]), input_nodes=[0], output_nodes=[], measurements={0: Measurement(alpha, Plane.XY), 1: Measurement(0.3, Plane.YZ)})
gflow = og.extract_gflow()
gflow_new: GFlow[Measurement] = gflow.subs(alpha, value) # mypy complains about the annotation.
Collaborator
There was a problem hiding this comment.
Oh, indeed! Sorry, I forgot that PauliFlow was not final.
Collaborator
There was a problem hiding this comment.
Oh, indeed! Sorry, I forgot that PauliFlow was not final.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the necessary methods to replace parametric angles by numerical values in
OpenGraph,PauliFlowandXZCorrectionsinstances.