Fix #253: add classes BaseCommand and BaseInstruction
#406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the classes `BaseCommand` and `BaseInstruction`, and removes the unused instructions `_XC` and `_ZC`. These classes can be used for type checking. They contrast with the type aliases `Command` and `Instruction`: - `BaseCommand` and `BaseInstruction` are open types and the user can define new subclasses. For instance, Veriphix introduces blind preparation commands and measurements. - `Command` and `Instruction` are closed types that contain exactly the commands of the measurement calculus (`N | M | E | C | X | Z | S | T`) and the instructions supported by the transpiler.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #406 +/- ##
==========================================
+ Coverage 84.87% 84.90% +0.02%
==========================================
Files 46 46
Lines 6639 6625 -14
==========================================
- Hits 5635 5625 -10
+ Misses 1004 1000 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
matulni
reviewed
Jan 5, 2026
Contributor
matulni
left a comment
matulni
left a comment
There was a problem hiding this comment.
Thanks, proposal is elegant and nice! I made a small comment only, otherwise looks good.
Contributor
|
Thanks! And good idea to generalize to the circuit instructions too. This might come in handy in veriphix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces the classes
BaseCommandandBaseInstruction, and removes the unused instructions_XCand_ZC. These classes can be used for type checking. They contrast with the type aliasesCommandandInstruction:BaseCommandandBaseInstructionare open types and the user can define new subclasses. For instance, Veriphix introduces blind preparation commands and measurements.CommandandInstructionare closed types that contain exactly the commands of the measurement calculus (N | M | E | C | X | Z | S | T) and the instructions supported by the transpiler.