Fix: Wayland 4:3 resolution support #171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SollyBunny
reviewed
Dec 26, 2025
Collaborator
SollyBunny
left a comment
SollyBunny
left a comment
There was a problem hiding this comment.
Regardless if this works or it's the correct solution this should be upstreamed to DDNet
| #if CONF_PLATFORM_LINUX && SDL_VERSION_ATLEAST(2, 0, 22) | ||
| // needed to workaround SDL from forcing exclusively X11 if linking against the GLX flavour of GLEW instead of the EGL one | ||
| // w/o this on Wayland systems (no XWayland support) SDL's Video subsystem will fail to load (starting from SDL2.30+) | ||
| if(Linked.major == 2 && Linked.minor >= 30) |
Collaborator
There was a problem hiding this comment.
I am not sure of the behaviour of SDL3 compat in this scenario, if Linked.major == 3, then this should be >= 2. Please try your setup with actual SDL2 (yay -S aur/sdl2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clarify, the main reason for this PR isn’t just about 4:3 support. On Wayland, I found that practically no resolution was working properly without bugging out or failing to start entirely.
Before these changes, I could only get a stable experience on native 1080p. This PR actually sorts out the scaling issues across the board for Wayland environments, ensuring that all resolutions now work smoothly without the usual bugs.
[ A quick note on the SDL_HINT_VIDEODRIVER change: I added this because I was seeing some flickering and inconsistent window initialization on startup under Wayland. Forcing this hint seems to settle the driver down and keeps the window behavior predictable. ]
Tested on: