Skip to content

Conversation

@TMUniversal
Copy link
Owner

No description provided.

TMUniversal and others added 30 commits August 12, 2025 16:41
Signed-off-by: Universal Studio <10200399+TMUniversal@users.noreply.github.com>
Signed-off-by: Universal Studio <10200399+TMUniversal@users.noreply.github.com>
Signed-off-by: Universal Studio <10200399+TMUniversal@users.noreply.github.com>
Signed-off-by: Universal Studio <10200399+TMUniversal@users.noreply.github.com>
Signed-off-by: Universal Studio <10200399+TMUniversal@users.noreply.github.com>
…er-3.x'

# Conflicts:
#	.github/workflows/build.yml
## [2.0.3](v2.0.2...v2.0.3) (2025-09-28)

### Bug Fixes

* **deps:** update module github.com/caarlos0/go-version to v0.2.2 ([7ae85c4](7ae85c4))
* **deps:** update module github.com/muesli/mango-cobra to v1.3.0 ([6ed0cdf](6ed0cdf))
* **deps:** update module github.com/spf13/cobra to v1.10.1 ([48d0a3f](48d0a3f))
* **deps:** update module github.com/stretchr/testify to v1.11.1 ([f9361d9](f9361d9))
* **deps:** update module golang.org/x/term to v0.35.0 ([00a4339](00a4339))
@TMUniversal TMUniversal requested a review from Copilot September 28, 2025 02:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the v2 branch with the latest changes, primarily focusing on upgrading dependencies and modernizing the codebase. The changes include upgrading the ProtonMail gopenpgp library from v2 to v3, updating various other dependencies, and transitioning from manual test assertions to the testify library.

  • Upgraded ProtonMail gopenpgp library from v2 to v3 with corresponding API changes
  • Updated multiple dependencies including Go version, testify, cobra, and GitHub Actions versions
  • Replaced manual test assertions with testify's assert functions for better test readability

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Updates Go version and multiple dependencies including gopenpgp v3 upgrade
internal/container_file.go Updates gopenpgp API calls for v3 compatibility
internal/container_file_v1.go Updates gopenpgp API calls and removes unused functions
internal/crc_test.go Replaces manual assertions with testify assert functions
cmd/generate.go Updates encryption logic for gopenpgp v3 API
cmd/scan_code.go Improves error handling and code organization
cmd/decode_test.go Replaces manual assertions with testify assert functions
THIRD_PARTY.md Updates license information for new dependency versions
CHANGELOG.md Documents the version 2.0.3 release changes
.goreleaser.yaml Removes conflicts configuration for homebrew cask
.github/workflows/*.yml Updates GitHub Actions versions to latest
Comments suppressed due to low confidence (1)

internal/crc_test.go:92

  • Duplicate validation logic exists - the same ValidateCRC24 call is performed both with assert.True and the old manual assertion pattern. The manual assertion (lines 89-92) should be removed since it's redundant with the testify assertion above.
	assert.True(
		t,
		ValidateCRC24(data, checksum),
		"Expected checksum validation to be true for pre-determined valid checksum, but got false.",
	)
	valid := ValidateCRC24(data, checksum)
	if !valid {
		t.Errorf("Expected checksum validation to be true, but got false.")
	}

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@TMUniversal TMUniversal marked this pull request as ready for review September 28, 2025 02:03
@TMUniversal TMUniversal merged commit 926d5a5 into v2 Sep 28, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants