Skip to content

Conversation

@MattiasBuelens
Copy link
Collaborator

On desktop, menus should appear in a popup in the bottom right corner of the player when the player is large enough. When the player becomes too small, the menu should take up the entire player size instead.

However, this broke in #122. We changed the @container query from (max-width: 500px) to (max-width: 500px) or (max-height: 300px), but the height of the container was always 0px! This is because we were using a padding-bottom hack to set the player's aspect ratio, which also needs height: 0 on the player.

Fix the regression by using aspect-ratio directly, and only falling back to padding-bottom when not supported. Fortunately, aspect-ratio predates @container, so we don't need to worry about the case where aspect-ratio is not supported but @container is supported. 😉

@MattiasBuelens MattiasBuelens requested a review from wjoosen January 7, 2026 12:42
@MattiasBuelens MattiasBuelens added the bug Something isn't working label Jan 7, 2026
@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026

🦋 Changeset detected

Latest commit: f5e1a9b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MattiasBuelens MattiasBuelens merged commit 3e3b93e into main Jan 7, 2026
1 check passed
@MattiasBuelens MattiasBuelens deleted the bugfix/desktop-menu-size branch January 7, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants