Fix menu size on desktop #131
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On desktop, menus should appear in a popup in the bottom right corner of the player when the player is large enough. When the player becomes too small, the menu should take up the entire player size instead.
However, this broke in #122. We changed the
@containerquery from(max-width: 500px)to(max-width: 500px) or (max-height: 300px), but theheightof the container was always0px! This is because we were using apadding-bottomhack to set the player's aspect ratio, which also needsheight: 0on the player.Fix the regression by using
aspect-ratiodirectly, and only falling back topadding-bottomwhen not supported. Fortunately,aspect-ratiopredates@container, so we don't need to worry about the case whereaspect-ratiois not supported but@containeris supported. 😉