Skip to content

Conversation

@wvanhaevre
Copy link
Contributor

This is a WIP PR for reporting THEOads AdTagParameters to Conviva.

TODO:

  • decide on the cleanest way to make use of the THEOdDescription type which is part of the THEOplayerTHEOadsIntegration

OPTIONS:

  • as implemented here: add the THEOplayerTHEOadsIntegration dependency to the conviva connector. THEOads is our own product, so makes sense to include it in our connectors.
  • make THEOdDescription available on the THEOplayerSDK-core, allowing to drop the extra dependency.
  • move adTagParameters property to AdDescription (already in THEOplayerSDK-core as a base class). But this might suggest to users that any adDescription can take additional adTagParameters.
  • others...

@wvanhaevre wvanhaevre requested review from Danesz, Dev1an and therama April 1, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants