Bugfix/conviva/fix encodingtype #106
Open
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvanhaevre
force-pushed
the
bugfix/conviva/fix-encodingtype
branch
2 times, most recently
from
c896b75 to
1926785
Compare
wvanhaevre
force-pushed
the
bugfix/conviva/persistent-metadata
branch
from
8bece75 to
bf8a5c1
Compare
…e sourcechange and for HESP after the sourceChange using a pending flag.
wvanhaevre
force-pushed
the
bugfix/conviva/fix-encodingtype
branch
from
1926785 to
b823397
Compare
| let adDescriptionMetadata: [String: Any] = collectAdDescriptionMetadata(from: convivaSessionSource.description) | ||
| metadata.merge(adDescriptionMetadata) { (_, new) in new } | ||
|
|
||
| // Do not override `encoding_type` value if already set by the customer. |
Contributor
There was a problem hiding this comment.
As discussed, I would add a bit more explanation why we need this extra code
Contributor
Author
There was a problem hiding this comment.
I added some comments to explain the flows for both HSL and HESP sources
MaartenRimaux
approved these changes
Jan 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.