Skip to content

Fix: correct sliceInRange stop clamp for non-zero origin domains (#164) #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianMichell merged 1 commit into from
Oct 1, 2025
Merged

Fix: correct sliceInRange stop clamp for non-zero origin domains (#164) #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions mdio/variable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,13 +965,15 @@ class Variable {

for (size_t idx = 0; idx < labels.size(); ++idx) {
if (labels[idx] == desc.label) {
// Clamp the descriptor to the domain.
return {desc.label, // label
desc.start < domain.origin()[idx] ? domain.origin()[idx]
: desc.start, // start
desc.stop > domain.shape()[idx] ? domain.shape()[idx]
: desc.stop, // stop
desc.step}; // step
// Clamp the descriptor to the domain using absolute coordinates.
// NOTE: domain.shape()[idx] is a size, not an absolute upper bound when
// the origin is non-zero. The correct exclusive upper bound is
// origin + shape.
Index dim_origin = domain.origin()[idx];
Index dim_upper = dim_origin + domain.shape()[idx]; // exclusive
Index clamped_start = desc.start < dim_origin ? dim_origin : desc.start;
Index clamped_stop = desc.stop > dim_upper ? dim_upper : desc.stop;
return {desc.label, clamped_start, clamped_stop, desc.step};
}
}
// We don't slice along a dimension that doesn't exist, so the descriptor is
Expand Down