Skip to content

Conversation

@dlines2008
Copy link
Contributor

Changing "We want to work with you. Contact the TCN Coalition" from a header to bold paragraph text (since it's not a header).
Adding a period at the end of the next to last sentence: "More information on the TCN Protocol is available on GitHub at https://github.com/TCNCoalition/TCN"

Changing "We want to work with you. Contact the TCN Coalition" from a header to bold paragraph text (since it's not a header).
Adding a period at the end of the next to last sentence: "More information on the TCN Protocol is available on GitHub at https://github.com/TCNCoalition/TCN"
## More Information

More information on the TCN Protocol is available on GitHub at https://github.com/TCNCoalition/TCN
More information on the TCN Protocol is available on GitHub at https://github.com/TCNCoalition/TCN.
Copy link
Collaborator

@dontuseyourrealnameontheinternet dontuseyourrealnameontheinternet May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making Github a hyperlink? E.g.

More information on the TCN Protocol is available on <a href="https://github.com/TCNCoalition/TCN">GitHub</a>.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you're asking me, but if you are I think it's good for users to be able to see the actual URL, and I would recommend that the link open in a new tab.

Copy link
Collaborator

@dontuseyourrealnameontheinternet dontuseyourrealnameontheinternet May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay then the URL would need to be enclosed in a target attribute.

<a href="https://github.com/TCNCoalition/TCN" target="_blank">https://github.com/TCNCoalition/TCN</a>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

enclosing URL in target attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants