-
Notifications
You must be signed in to change notification settings - Fork 2
GH-88: System Specs Plugin #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add DataList plugin support. - Require description. - Edit "Resources Title" verbose name. - Update To Do list. - Rebuild migrations. - Rebuild specifications using table.
Enable the link by adding missing context variables. TODO: Prevent duplicate entires in "Internal Link".
Do not let "Internal Link" have duplicate options.
For System Monitor, Image / Picture, and DataList: - Limit System Specs child plugins to these. - Style these in System Monitor layout. - Load System Monitor styles via new `app.*` stylesheet.
This prepares for the rename that occurs in task/GH-89.
iamthatian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works well! Will approve.
One question I had was if there should be a limit to how long the description should be?
It seemed to break the style if the description gets too long.
Co-authored-by: Ian Park <contact@duckonomy.com>
|
@duckonomy Changes made.
Yes. Excellent catch. I've set 500, which is: Reasoning
Extra ThoughtsThe problem with text limits is that on some window widths the text may be "too much" and on some window widths the text is not enough. But some limit should exist to prevent someone from entering the text of a novel, or relying solely on "Description" when they should use a Data List table. |
iamthatian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
To Do (Done)
Overview
Create System Specs plugin.
Issues
Screenshots
Form
Render
TACC: Shared UI - Constants - Breakpoints
Structure
The "Style" elements are a necessary evil until I create Section plugin (GH-91).
Testing
If no environment, then prepare to test CMS changes.
In CMS container, run
python3 manage.py migrate.On CMS website, logged in as admin, create a new "Frontera System" page.
On the new page:
(optional) Choose "Standard" template (to get Breadcrumbs).
(optional) Add two "Generic" > "Style" plugins (to create Sections) with:
Details
---------sectiono-section, o-section--style-light(required) Add "TACC Site" > "System Specs" plugin (optionally within "Style" plugin).
(optional) Add "TACC Site" > "Callout" plugin with any content (optionally within "Style" plugin).
Ensure the following behavior:
Required Behavior
Notes
This plugin will be used first on [Frontera System page], and then on TACC system pages (e.g. stampede2, longhorn, stockyard).