Skip to content

Conversation

@jcdoll
Copy link
Contributor

@jcdoll jcdoll commented Dec 29, 2025

Hi -
Here is a pull request for a new plugin to show HLTB time estimates.

I initially did the backend in python, but saw your other PR comments so ported it to Lua.

Background: I enjoy the HLTB plugin on Steam Deck and, when I couldn't find the same thing on desktop, went down the rabbit hole of finding your project and deciding to make a plugin.

Thanks for reviewing!
Joey

@shdwmtr
Copy link
Member

shdwmtr commented Dec 30, 2025

Thanks for the PR!

reference:
Import useState from React directly, don't use internal variables as they are subject to change without notice.

import { useState } from 'react';

Other than that, all seems good. We can proceed with testing once we resolve the issue above!

@jcdoll
Copy link
Contributor Author

jcdoll commented Dec 30, 2025

Thanks! Fixed and PR updated
jcdoll/hltb-millennium-plugin@f2c688b

@shdwmtr
Copy link
Member

shdwmtr commented Dec 30, 2025

Your plugin has been built. Verify it works as expected and contains all the files that it should.

https://github.com/SteamClientHomebrew/PluginDatabase/actions/runs/20604057114/artifacts/4993692855

@jcdoll
Copy link
Contributor Author

jcdoll commented Dec 30, 2025

one correction - version number was missing from plugin.json because i had been autoinjecting it with a gh action. switched to manual entry to match release process and other plugins. PR updated.

besides that i tested and checked files and everything looks good.

@shdwmtr
Copy link
Member

shdwmtr commented Dec 30, 2025

Check the new build!

@jcdoll
Copy link
Contributor Author

jcdoll commented Dec 30, 2025

lgtm!

  • checked file contents
  • installed and check functionality

@shdwmtr
Copy link
Member

shdwmtr commented Dec 30, 2025

Perfect, I just need a third party to test the plugin. You'll likely easily find someone in our discord!

@jcdoll
Copy link
Contributor Author

jcdoll commented Dec 30, 2025

horn of gondor has been sounded

@shdwmtr
Copy link
Member

shdwmtr commented Dec 31, 2025

Perfect, it's been tested.

One last thing, you'll need to remove "Manual Installation" from the README. The README should not guide users to install your distribution of the plugin, as it's not moderated or verified by us.

@madmaxgrey
Copy link

plugin has been tested by me and works as intended on the latest stable

@jcdoll
Copy link
Contributor Author

jcdoll commented Dec 31, 2025

nuked the manual install section, kept a general install section w/ link to plugins page, updated submodule link but kept version number at 1.0.3

new readme section:

  1. Ensure you have Millennium installed on your Steam client
  2. Navigate to HLTB from the plugins page
  3. Click the "Copy Plugin ID" button
  4. Back in Steam, go to Steam menu > Millenium > Plugins > Install a plugin and paste the code
  5. Follow the remaining instructions to install and enable the plugin

@shdwmtr shdwmtr merged commit 5a3272f into SteamClientHomebrew:main Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants