-
Notifications
You must be signed in to change notification settings - Fork 17
Add HLTB for Steam plugin #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! reference: import { useState } from 'react';Other than that, all seems good. We can proceed with testing once we resolve the issue above! |
|
Thanks! Fixed and PR updated |
|
Your plugin has been built. Verify it works as expected and contains all the files that it should. https://github.com/SteamClientHomebrew/PluginDatabase/actions/runs/20604057114/artifacts/4993692855 |
|
one correction - version number was missing from plugin.json because i had been autoinjecting it with a gh action. switched to manual entry to match release process and other plugins. PR updated. besides that i tested and checked files and everything looks good. |
|
Check the new build! |
|
lgtm!
|
|
Perfect, I just need a third party to test the plugin. You'll likely easily find someone in our discord! |
|
horn of gondor has been sounded |
|
Perfect, it's been tested. One last thing, you'll need to remove "Manual Installation" from the README. The README should not guide users to install your distribution of the plugin, as it's not moderated or verified by us. |
|
plugin has been tested by me and works as intended on the latest stable |
|
nuked the manual install section, kept a general install section w/ link to plugins page, updated submodule link but kept version number at 1.0.3 new readme section:
|
Hi -
Here is a pull request for a new plugin to show HLTB time estimates.
I initially did the backend in python, but saw your other PR comments so ported it to Lua.
Background: I enjoy the HLTB plugin on Steam Deck and, when I couldn't find the same thing on desktop, went down the rabbit hole of finding your project and deciding to make a plugin.
Thanks for reviewing!
Joey