Skip to content

Add meta tags to the hub #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Snailedlt wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add meta tags to the hub #120

Snailedlt wants to merge 4 commits into from

Conversation

@Snailedlt
Copy link
Member

@Snailedlt Snailedlt commented Mar 26, 2025

Add meta tags, improve SEO and optimize images

@Snailedlt Snailedlt requested a review from r-mach March 26, 2025 20:16
r-mach
r-mach requested changes Mar 27, 2025
View reviewed changes
Copy link
Member

@r-mach r-mach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to separate linting from real modifications to ease further reviews! <3
Could you please keep the package-lock.json untouched (revert your changes on it thanks)

@Snailedlt Snailedlt force-pushed the add-meta-tags-to-the-hub branch from 897df6a to 9175370 Compare March 27, 2025 18:32
@Snailedlt Snailedlt requested a review from r-mach March 27, 2025 18:32
@Snailedlt
Copy link
Member Author

Snailedlt commented Mar 27, 2025

The package-lock.json changes were not meant to be included, same goes for the changes in publications.js.

I've rebased the PR on main and re-applied the changes now. Hopefully it should be easier to review now as well

r-mach
r-mach requested changes Apr 7, 2025
View reviewed changes
r-mach
r-mach requested changes Apr 7, 2025
View reviewed changes
Copy link
Member

@r-mach r-mach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide better file names for your two screenshots in the public folder

@Snailedlt Snailedlt requested a review from r-mach April 8, 2025 19:03
@Snailedlt
Copy link
Member Author

Snailedlt commented Apr 8, 2025

Sorry about that. I didn't realize that my testing images had been committed.
Hopefully it's all fixed now.

Here's a preview of what it should look like on different sites:
screencapture-opengraph-xyz-url-https-hub-splitscreen-me-2025-04-08-21_05_17

@Snailedlt
Copy link
Member Author

Snailedlt commented May 16, 2025

@r-mach does it look okay now? Sorry about the many back-and-forths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@r-mach r-mach Awaiting requested review from r-mach

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Snailedlt @r-mach