Mastercraft-enroll-ui-build #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Ase020 you have a merge conflict in the PR. Kindly fix this. |
❌ Deploy Preview for spaceyatech failed. Why did it fail? →
|
njeririziki
approved these changes
Jun 5, 2025
njeririziki
left a comment
njeririziki
left a comment
There was a problem hiding this comment.
some long functions like handleContinue() in MastercraftEnrollmentComponent could be optimized otherwise looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Proposed changes
Warning
Please read these points carefully and answer honestly with an
Xinto all the boxes. Example : [X]
Before submitting a pull request make sure you have:
How to Check and Fix Linting Issues
Run
npm run validate. This command will run prettier and eslint checks to ensure linting guidelines are respected.If the command exits with code 0 (build is successful), there are no linting issues.
If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.