Skip to content

Conversation

@AndrewBarber
Copy link
Member

Remove package-lock.json files and update GitHub Actions

Summary

This PR makes several improvements to the repository:

  1. Removes package-lock.json files from git tracking and adds them to .gitignore
  2. Updates GitHub Actions workflows to use npm install instead of npm ci
  3. Adds NPM Publish badge to the README

Rationale

Removing package-lock.json follows best practices for npm packages, as package-lock.json should not be committed to repositories for libraries that will be consumed by other projects. For npm packages like this one:

  • It allows consumers to resolve dependencies based on their own environment
  • It prevents potential conflicts with consumers' dependency trees
  • It provides more flexibility with dependency version resolution
  • It aligns with npm's official recommendations for published packages

The GitHub Actions workflows have been updated to use npm install instead of npm ci since npm ci requires a package-lock.json file.

Changes

  1. Adding package-lock.json to .gitignore
  2. Removing existing package-lock.json files from git tracking
  3. Updating GitHub Actions workflows to use npm install
  4. Adding NPM Publish badge to README

@AndrewBarber
Copy link
Member Author

This will work correctly once S48-2368_SDM-Connectors-Issue-with-Node-fetch is merged in.

@AndrewBarber AndrewBarber merged commit 8e5ac83 into master May 13, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants