-
Notifications
You must be signed in to change notification settings - Fork 137
Improve tests and increase coverage #1666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Seperate sample quorum * Rename to computeMaxRequiredSignatures
…owbridge into ron/fix-quorum-check
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
It looks like we need to configure the Copilot agent according to |
This PR addresses feedback from code review to remove unnecessary code and adds comprehensive test coverage for critical components.
Changes
deposit()function that was a v1 artifact for agent fee management, no longer needed in v2validatePadding()to enforce zero-padding in bitfields, preventing malformed bitfield attackssubmitInitial(),submitFinal(), andsubmitFiatShamir()flowsMerkleLibhelper to eliminate duplicated Substrate-compatible Merkle tree construction across test filesSecurity improvements
The bitfield padding validation prevents adversaries from submitting bitfields with malicious padding bits that could bypass signature verification checks:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.