-
Notifications
You must be signed in to change notification settings - Fork 54
Added support for different parity settings and YTL meter #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mstegen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Arjan,
I don't think this will work, as the config bytes are pre-set when flashing the controller for the first time, and should not be modified with the bootloader.
Also, as there is no external pull up on the MCLR line, setting it to external while noting is connected to the pin, can cause resets. (even with the internal weak pull up)
mstegen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thanks.
You're right, I did a flash with a pickit to set this. It is not a must have as you can enter and exit bootloader via protocol. I added it because I was stuck once or twice in the bootloader during debugging (by faulty baudrate detection I guess.).
Ok, I had expected the internal pull-up to be sufficient. I'll remove it in my next push. BTW still running some tests, hence the draft status. |
- Fixed YTL byte order - Added phase currents to display - Error detection for all meters - Display Connected for STATE_B
|
Added further improvements and fixes and tested properly. |
Uh oh!
There was an error while loading. Please reload this page.