Compile updates and modernizations #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This patch does not implement alternate character set handling, only negotiation. All text coming from servers is assumed to be UTF-8, regardless of negotiated character set. This patch does not implement the TTABLE option.
* Now case-insensitive * Handles null character sets (a possibility!) * Doesn't rely on constant in inner for-loop. * Best-case isn't O(n^2) in inner for-loop.
Add Telnet character set negotiation
This function was deprecated and replaced with pcre_fullinfo a while back. Should be able to squeeze a few more years out of the old girl this way.
add wrapper to replace pcre_info function
- Add .gitignore. - Add -Wl,--allow-multiple-definition to LDFLAGS for gcc (does not build otherwise.) - Use mkdir -p instead of mkdir in unix.mak, install to a stow dir will fail otherwise. TODO: Check build on macOS. Signed-off-by: Rafael Kitover <rkitover@gmail.com>
Fix build on modern linux.
Compile updates and modernization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various cleanups and modernizations of compilation, removal of vestigial bits, integration of stuff from other forks.
I'm a little confused about Makefile.in and Makefile, but it looks like Makefile must have been manually edited a long time ago and Makefile.in never updated, I'll come back to that one later.
Completely forgot to squash my commits before merging them into my my main branch, hopefully you'll have the good sense to do that when merging these in yourself.