Introduce smc_Request

[live627]

• AJAX refactor: Replaced all jQuery $.ajax calls with the Fetch API and Promises.

  • Introduced a new smc_Request class with static fetch and fetchXML methods, supporting timeouts and credential options.
  • getServerResponse, getXMLDocument, and sendXMLDocument now use Fetch and return Promises, calling callbacks if provided.

• Improved error handling: Uses Promise.reject and catches network errors; callbacks receive false on failure.

• Popup and menu handling:

  • reqOverlayDiv and smc_PopupMenu now use fetch and native DOM methods instead of jQuery for content loading and event handling.

[jdarwood007]

Can you also add the logic for handling JSON?
I had envisioned that we would replace our XML responses with JSON responses to take advantage of the more native handling of data. One step at a time, but if this is in place here, those steps become easier to do.

[sbulen]

Almost like we need a response type, to make it easier to avoid rendering http themes.

[live627]

		smc_Request.fetch(url)
			.then(res => res.json())
			.then(function(jsonArray) { /* ... */ });

[jdarwood007]

		smc_Request.fetch(url)
			.then(res => res.json())
			.then(function(jsonArray) { /* ... */ });

Fair enough. Mentioned because of the static function just for handling xml.

[live627]

right, that's because there is no quick built in function call

…

On Tue, Aug 26, 2025 at 8:17 PM Jeremy D ***@***.***> wrote: *jdarwood007* left a comment (SimpleMachines/SMF#8884) <#8884 (comment)> smc_Request.fetch(url) .then(res => res.json()) .then(function(jsonArray) { /* ... */ }); Fair enough. Mentioned because of the static function just for handling xml. — Reply to this email directly, view it on GitHub <#8884 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJNN67M6MDJBEJW5RWS233PUPOBAVCNFSM6AAAAACE2BU2T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEMRWGYYDEOJQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jdarwood007]

The code looks good.

However, I can't complete a quick edit. All I did was click quick edit and then save. Never completes the save.

[live627]

I just got the upgrader to work for me. I'll test this now.

…

On Wed, Sep 10, 2025 at 6:10 PM Jeremy D ***@***.***> wrote: ***@***.**** commented on this pull request. The code looks good. However, I can't complete a quick edit. All I did was click quick edit and then save. Never completes the save. — Reply to this email directly, view it on GitHub <#8884 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJNN57XBZP2OA4PS74STD3SDDZ7AVCNFSM6AAAAACE2BU2T6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTEMBYGMZTMMZYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[live627]

Oh I see what's going on. It sends an object, which this new userland code treats as JSON. We must send a string so it sends the proper header.

[jdarwood007]

That works but the Jump to never loads

[jdarwood007]

With your jumpto changes, can that JavaScript now be called with a defer?

Some JS goals I had were to move everything into defer and use the calls for inline JavaScript to send them to the bottom of the page. Then look at doing noonce on all scripts and CSS. One step at a time would be if JS is getting updated, can it be deferred, which makes the later steps easier to accomplish later.

[live627]

I was planning to defer scripts in a future PR, but I decided to defer topic.js here 9ece101 so you would be able to see that each individual call in the templates would need to be deferred as well.

[jdarwood007]

That's fine. As long as we are making the right progress towards where we can make that step happen more easily without rewriting them again. The ultimate goal for our JS in my mind is that our libraries can be loaded in the head with async, and the calls that set up the logic in the app are deferred until the end.

[jdarwood007]

Safe to review again or do you have more incoming?

[live627]

go ahead

…

On Sat, Sep 13, 2025 at 4:42 PM Jeremy D ***@***.***> wrote: *jdarwood007* left a comment (SimpleMachines/SMF#8884) <#8884 (comment)> Safe to review again or do you have more incoming? — Reply to this email directly, view it on GitHub <#8884 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADJNN33KIPQN5YNMM3XXFD3SSTWRAVCNFSM6AAAAACE2BU2T6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTEOBYHE3DINJYGM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[jdarwood007]

Two issue.

1. Jump to a board and it takes you to the wrong url
2. When you try to quick edit a post: Uncaught ReferenceError: oQuickModify is not defined

[live627]

• I'll fix the quick modify error in [3.0] Update quick modify to support Ctrl+Enter #8886 if you don't mind.