Skip to content

Conversation

@dragomano
Copy link
Contributor

This PR moves third-party libraries (Minify and ReCaptcha) to a separate subdirectory within Sources — Libs.

It also adds a command (see composer.json in the root) to update these libraries (experts can to configure this command to run before building the package so that the Libs folder is included in the SMF distribution package).

Also implemented are 2 of SMF's own classes, JS and CSS, which extend the external classes MatthiasMullie\Minify\JS and MatthiasMullie\Minify\CSS respectively. This is done to add an additional comment at the top of each minimized file (previously this required changes to the updated Minify.php each time).

This way, external libraries can be easily updated with each release.

Fixes #7977

Signed-off-by: Bugo <cheetah@bk.ru>
Signed-off-by: Bugo <cheetah@bk.ru>
Signed-off-by: Bugo <cheetah@bk.ru>
@Sesquipedalian Sesquipedalian added the Meta Repository tools/code reorganization label Feb 6, 2024
@dragomano dragomano marked this pull request as draft January 23, 2025 06:17
@dragomano dragomano closed this May 3, 2025
@live627
Copy link
Contributor

live627 commented May 4, 2025

Also implemented are 2 of SMF's own classes, JS and CSS, which extend the external classes MatthiasMullie\Minify\JS and MatthiasMullie\Minify\CSS respectively. This is done to add an additional comment at the top of each minimized file (previously this required changes to the updated Minify.php each time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Meta Repository tools/code reorganization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReCaptcha Lib needs updated for 3.0

3 participants