Virtual Host Support #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in. If no vhost specified passed in plugin behaves the same as before.
Contributor
Author
|
Any feedback on this pull request? |
Contributor
Author
|
Hi @SimonDegraeve , Just following up on this pull request. If you have any feedback, do you let me know. If you could merge this in I think it would be helpful for others with more complex projects. |
|
@mashaalmemon Thanks for the PR for vhosts, and thanks @SimonDegraeve for (possibly) merging it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SimonDegraeve,
As mentioned in #13 I have modified plugin to support virtual hosts/route information if passed in. If no vhost specified passed in plugin behaves the same as before. Multiple instances of plugin, each for different vhost and different webpack configuration, are now supported.
Ultimately there are no breaking changes for past users, but new functionality for those wishing to support more complex setups with vhosts.
The readme has been updated accordingly.
Hopefully you can find some time push this one out soon. Let me know if you'd like me to modify adjust/anything further. I don't see any other changes being made to the plugin anytime soon (unless a bug is found).