-
Notifications
You must be signed in to change notification settings - Fork 156
Sync URI::Source with RubyLSP
#2475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
URI::Source#fragmentURI::Source with RubyLSP
|
The test failures are legit. In our source URIs, the gem version after the name is optional. When it's missing, it indicates whatever version is currently activated in a Bundle context. |
|
|
||
| # We need to hide these aliased methods from Sorbet, because it would otherwise complain about these | ||
| # being redefinitions of the existing methods it knows about from RubyLSP. | ||
| self #: as untyped # rubocop:disable Style/RedundantSelf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this since host and fragment are defined in the RBI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but for a different reason now. See the comment on lines 29-30
I renamed this class from Tapioca::SourceURI to URI::Source (same as what RubyLSP would define), so these are redefinitions of those methods now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
Co-authored-by: Vinicius Stock <vinicius.stock@shopify.com>
d03cd25 to
8a51701
Compare
8a51701 to
cd56d1f
Compare

Motivation
Fixes #2471
URI::Source#fragmentalias_methodURI::Sourcewith Tapioca ruby-lsp#3891)delete_prefix("/")in the path parsing code/in theURI::Source#to_soutput