fix: $RS is not defined #75
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`$RS` is defined in `English` module. I suppose that `$RS` is introduced here for Style/SpecialGlobalVars cop of RuboCop, but the module is not required here. Instead of using the input record separator, this patch uses the NUL character as a separator.
Member
Edouard-chin
left a comment
Edouard-chin
left a comment
There was a problem hiding this comment.
Thank you for the pull request !
I made a suggestion as I think using git is a bit overkilled for such a small project
since this is a small project Co-authored-by: Edouard CHIN <chin.edouard@gmail.com>
Edouard-chin
approved these changes
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$RSis defined inEnglishmodule. I suppose that$RSwas introduced here for Style/SpecialGlobalVars cop of RuboCop, but the module is not required here.Instead of using the input record separator, this patch uses
the NUL character as a separator.a simple file list.