[ENGINE-8673]: Adding estimated import charges in shipments #121
Conversation
r3dnaxel
requested review from
AndrewBenzSW,
ChristianCasado,
Moratojkd and
agustinmartinpck
AndrewBenzSW
left a comment
AndrewBenzSW
left a comment
There was a problem hiding this comment.
I stopped the review because I think you re-extracted the generation templates, which we shouldn't do. This is my fault because the README doesn't call out that the template extraction command is there for informational purposes and should generally not be run.
README.md
Outdated
| *Webhooks* | [**GetWebhookById**](docs//apis/WebhooksApi.md#getwebhookbyid) | Get Webhook By ID | ||
| *Webhooks* | [**ListWebhooks**](docs//apis/WebhooksApi.md#listwebhooks) | List Webhooks | ||
| *Webhooks* | [**UpdateWebhook**](docs//apis/WebhooksApi.md#updatewebhook) | Update a Webhook | ||
| *Account* | [**CreateAccountImage**](docs/\apis/AccountApi.md#createaccountimage) | Create an Account Image |
There was a problem hiding this comment.
What caused all these lines to change? I see the slash in front of /apis has been changed to \apis, so I'm guessing this is a Mac/Windows thing? We should figure it out because it adds a lot of noise.
There was a problem hiding this comment.
I'm not sure what's causing this url format issue, probably is connected with OS (Windows vs Mac), I just followed the procedure described here as you suggested. I'll adjust those urls manually but agree that We need to figure out how to avoid this
| /// <param name="cancellationToken">Cancellation Token to cancel the request.</param> | ||
| /// <returns>Task of ApiResponse (CreateTagResponseBody)</returns> | ||
| Task<CreateTagResponseBody> CreateTag(string tagName, CancellationToken cancellationToken = default); | ||
| Task<CreateTagResponseBody> CreateTag_0(string tagName, CancellationToken cancellationToken = default); |
There was a problem hiding this comment.
Do we know why this got created as CreateTag_0? That seems kinda strange.
There was a problem hiding this comment.
maybe It is connected to these Tags API changes
We added a new endpoint with the same name than the old one, the second one marked as deprecated, so probably It generates the name of the old one with that "_0" suffix to differentiate them
I generated the SDK changes again removing the templates for auto-generation step |
docs/apis/AccountApi.md
Outdated
| |------|------|-------------|-------| | ||
| | **methodClient** | [**HttpClient**](https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient?view=netstandard-2.0) | The HttpClient instance to use for the request. | | | ||
| | **createAccountSettingsImageRequestBody** | [**CreateAccountSettingsImageRequestBody**](../../docs//models/CreateAccountSettingsImageRequestBody.md) | | | | ||
| | **createAccountSettingsImageRequestBody** | [**CreateAccountSettingsImageRequestBody**](../../docs/\models/CreateAccountSettingsImageRequestBody.md) | | | |
There was a problem hiding this comment.
Does this link work? The double forward slash that was there previously seems iffy, but I think a backslash will cause the link to break. Same comment applies for the rest of the links. I'm guessing this is a generation issue with the difference between Mac and Windows? If so, I can take a look at the template.
There was a problem hiding this comment.
yup, It looks like a Mac-Windows issue, I'll fix it manually for now
Related to ENGINE-8673