feat(ForceFeedback): add dbus interface for scale #489
+157
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowApex
force-pushed
the
lukeshortcloud/force-feedback-scale
branch
4 times, most recently
from
0be7c9d to
b614364
Compare
Control the sensitivity of force feedback.
ShadowApex
force-pushed
the
lukeshortcloud/force-feedback-scale
branch
from
b614364 to
86aa9fa
Compare
Contributor
|
I'm not convinced about this approach. I think it makes more sense to handle at the source device level instead of at the event level. Some devices have a hardware scale built in. How should we handle that? I.e. setting it to 1.0 when the hardware is at half intensity already could lead to confusion. Do we just hard enable max intensity? What if a device has both haptics and rumble sensors, but one of the two sensors is far to aggressive while the other is fairly good. By scaling it globally you just inverted the problem instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control the sensitivity of force feedback.