Skip to content

Conversation

@JhonTabio
Copy link

Seems like CBScript only supported "block" for loot tables.

So now you should be able to define an entity loot table as follows:

loot_table entity minecraft:entity_type_here {
    # All the JSON goodies go here
}

More information on the issue I posted

JhonTabio added 2 commits May 17, 2024 02:59
…e_type types. This allows for the creation of entity loot tables
@JhonTabio JhonTabio changed the title 'Entity' added in the scriptlex token list 1.21+ patch / 'Entity' added in the scriptlex token list Jul 18, 2024
@JhonTabio
Copy link
Author

Updated mcworld.py to create folders with names that the newer 1.21+ versions would query for.

@AVDestroyer
Copy link

Would it be better to include both the new folder name format and the old folder name format in the datapack to make it compatible with both pre and post 1.21 versions? As far as I know that shouldn't cause any conflicts.

@JhonTabio
Copy link
Author

Would it be better to include both the new folder name format and the old folder name format in the datapack to make it compatible with both pre and post 1.21 versions? As far as I know that shouldn't cause any conflicts.

I have not tried something like this, though I also don't see an issue (Aside from bloat files of the other version not currently in use). The pack_format should remain the same, so depending on the version, the new or old folder format would be read in.

Personally, I think the best approach if you truly want the software to be able to generate both versions is to just have a new parameter when running the script that flips between the old or new format. This would at least keep a single consistent folder structure instead of having double at once

@AVDestroyer
Copy link

Yeah I think you are right, ideally there should be another CLI argument with the Minecraft version for compile.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants