Skip to content

Conversation

@jnoordsij
Copy link
Contributor

Current image build jobs are failing due to the update to Alpine 3.23, see e.g. https://github.com/ServerContainers/samba/actions/runs/20080713627/job/57606814068. This is caused by the issue described at https://gitlab.alpinelinux.org/alpine/aports/-/issues/17775. Although not entirely resolved yet, an update to apk-tools has been issued which should effectively solve this issue. This PR aims to fix builds by forcing this update to be pulled on building. It can be reverted once the base Alpine Docker image includes this version by default.

Note: I've not yet tested if this actually fixes builds, but CI should show that soon enough...?

@jnoordsij jnoordsij marked this pull request as draft December 10, 2025 09:25
@jnoordsij jnoordsij force-pushed the fix-alpine3.23 branch 2 times, most recently from df897b2 to 628d0e6 Compare December 10, 2025 09:38
@MarvAmBass
Copy link
Member

thanks so much - I was wondering why it's failing, tested it on my local machine, and it was able to build without a problem...
thanks for diving deeper into it and finding the issue!

I'm not sure, if we should merge a temporary fix - I'm hoping this will be resolved within 1-2 weeks automatically. and I don't think we have an urgency to upgrade - it's just ugly that the build here fails

what do you think?

@jnoordsij
Copy link
Contributor Author

Looking into it I just figured that no new apk-tools version has been tagged, so the whole idea of patching this way won't work unfortunately. There's basically two ways that might solve the issue still:

  1. add the --no-scripts flag (temporarily) to the 'real' apk calls to disable the busybox trigger; this is probably harmless, but definitely somewhat ugly
  2. add a docker/setup-qemu-action@v3 step to the GitHub CI workflow as suggested (as optional step) per github.com/docker/setup-buildx-action?tab=readme-ov-file#usage, which others have reported to work as a fix to this particular issue

I'll create a new PR with option 2 just to see if it helps. Also for me, definitely no hurry, as indeed in a few weeks this issue should probably be addressed and subsequently released from upstream. Just me looking forward to Samba 4.22 with directory leases, which should somewhat help in performance/server load ;)

@jnoordsij jnoordsij closed this Dec 10, 2025
@jnoordsij jnoordsij deleted the fix-alpine3.23 branch December 10, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants