Clarify that dimmer.settings.closable is boolean #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation simply states that `closable` has a default of `auto` but doesn't state what other values it can take; I had to [check the code](https://github.com/Semantic-Org/Semantic-UI/blob/master/src/definitions/modules/dimmer.js#L364) to see that it's actually a boolean with logic to account for an `auto` flag. This change updates the docs to reflect this more clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation simply states that
closablehas a default ofautobut doesn't state what other values it can take; I had to check the code to see that it's actually a boolean with logic to account for anautoflag. This change updates the docs to reflect this more clearly.