Test PR - Large Refactor - first stage #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves files around and starts to use the new architecture. Tests need to be sorted out still. There's a bunch we still need to move out of the UI code, ideally.
This was too much metadata on images, it wasn't needed. - Removed commented filter state: Deleted the selectedFilter state variable - Removed filter functionality: Eliminated the filteredPhotos computed property and related filtering logic - Updated photo display: Changed from filteredPhotos to photos in the LazyVGrid - Removed filter menu: Deleted the commented "Filter Photos" menu from the toolbar - Deleted filter files: Removed PhotoFilter.swift and PhotoFilterTests.swift completely - Updated photo detail navigation: Fixed the navigation to use photos instead of filteredPhotos
This was a huge in-progress changeset, not sure if it's working but there are a lot of good little changes here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves files around and starts to use the new architecture.
Tests need to be sorted out still.
There's a bunch we still need to move out of the UI code, ideally.