Python3 #22
Open
Python3 #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahirijaz24
commented
Jun 6, 2018
tahirijaz24
commented
- Includes some changes to sharpy to make it work with python3
Update the plans to a table to include the names and number of tracked items. Some Unit tests are checking against these.
… to parse. Bubble up coupon code to promotion.code.
…n cheddar's side.
…clude a __repr__ for Promotion.
…esults. Related to a specific cheddar bug where it only returns .
…emove the skip test decorator from unit tests. Add work around for duplicate transaction failures.
Unit tests are passing. Coverage is 99%.
Add 'plans' to Promotion and PromotionParser. See #3141
Clean credit card info from debug logs
Catch KeyError
Fix keyerror
Check that cc info is in the request before removing it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.