Add JET.jl static analysis tests and Real type annotations #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Real type annotations to λ parameter in all functions (pois_rand, count_rand, ad_rand, procf) for better static analysis compatibility - Add JET.jl as a test dependency with broad version compat (0.9-0.11) - Add JET static analysis tests using @test_opt and @test_call macros to verify type stability and catch potential runtime errors All JET analysis passes with zero reports, confirming the package is type-stable and ready for Julia's compilation improvements. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Realtype annotations to theλparameter in all functions (pois_rand,count_rand,ad_rand,procf) for better static analysis compatibility@test_optand@test_callmacros to verify type stability and catch potential runtime errorsDetails
Type Annotations Added
The
λparameter was previously untyped duck-typing. Since the functions require numeric operations (sqrt,floor, comparisons, etc.), addingRealas a type annotation:JET Tests
Added two test sets in
test/qa.jl:@test_opt) - Verify no type instabilities in the core functions@test_call) - Verify no potential runtime errorsAll JET analysis passes with zero reports, confirming the package is type-stable.
Test plan
Pkg.test()- All tests passCC @ChrisRackauckas
🤖 Generated with Claude Code