Tests refactorization #10
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejaszek
force-pushed
the
tests
branch
2 times, most recently
from
ac932a5 to
4cb22ff
Compare
Tests in requests packaged are overhauled: * Unification: Ginkgo/Gomega is dropped in favour of Testify. * Tests are mostly organized into Testify suites. * Subtests are used extensively. * Subtests are mostly run in parallel. Some reasons why Testify has been chosen: * It's more popular (widely used) than Ginkgo. * Some of Ginkgo functionality was deprecated ans will be removed in V2. * It's easier for Golang devs to start writing tests in Testify. Signed-off-by: Maciej Wereski <m.wereski@partner.samsung.com>
Signed-off-by: Maciej Wereski <m.wereski@partner.samsung.com>
Tests were rewritten from ginkgo to testify, new testcases were added to improve coverage. For reason of dropping ginkgo please see commit aeca476. Additionaly deprecated ioutil function was dropped and documentation was updated with information about potential panic in config Unmarshal. Signed-off-by: Maciej Wereski <maciey@members.fsf.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls tests and focuses especially on: