-
Notifications
You must be signed in to change notification settings - Fork 619
Improve download speed, and adaption for new pm command about BK7239N #7099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: BK7239N_Support
Are you sure you want to change the base?
Conversation
ziliguo
commented
Dec 26, 2025
- HW checksum for T-Put further optimization;
- Improve the download speed;
- adaption for "power start -l"
- Support of image encryption.
|
@ewoodev @hk-gwak @jylee9613 Could you review this? |
|
@ziliguo Could you let us know details of |
Hi @sunghan-chang ,
For the noise issue with high-speed you have mentioned, we use flow below to keep stability:
|
| required = ["kernel", "bootparam"] | ||
| optional = ["app1", "app2", "userfs"] | ||
| if self.config.get("CONFIG_BINARY_SIGNING", "n") != "y": | ||
| if self.config.get("CONFIG_TFM", "n") != "y": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ziliguo : Please explain what is effect of this change ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amandeep-samsung ,
Before this modification was added, the bootloader was packaged within all-app.bin. After this modification, the bootloader can be separated from all-app.bin. This allows all-app.bin to be downloaded via the bootloader, and the bootloader includes optimizations for download speed.
@ziliguo Latency Timer (msec) value is not changed in Realtek case, and we use same settings as 16 msec for it.
|
apps/examples/power/power_main.c
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for find this issue.
We'll fix this issue for master branch.
For now use power start -l -t.
And when master branch is updated, you can cherry-pick that code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @seokhun-eom24, got it. Once you update to the master branch, we will sync the PM changes to this BK7239N_Support branch. We will revert this commit for now. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's merged now. you can revert this commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay. It has already been reverted now.
| return status; | ||
| } | ||
|
|
||
| int verify_firmware_signature(uint32_t address) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
verify_firmware_signature seems verify only app binary signature.
How can we verify kernel binary? Would you please add up_verify_usersignature too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @jylee9613, during each startup, the bootloader verifies the signature of the kernel image, and only if the verification passes will it execute the kernel code; however, in the application code, the interface up_verify_kernelsignature has not been properly adapted yet. We will provide this interface in the future. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that verify_firmware_signature is used only in internal. How about change this API to static?
We only use up_verify_usersignature/up_verify_kernelsignature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jylee9613 Yes, of course. It has already been updated to static now.
Hi @amandeep-samsung , thank you for your valuable suggestion. The MP Tools team will consider this request and conduct a feasibility assessment. |
- Move WiFi APIs to RAM, thus to improve more transfer performance; - Allocate more flash partition size for kernel
- Before this modification was added, the bootloader was packaged within all-app.bin. - After this modification, the bootloader can be separated from all-app.bin. - This allows all-app.bin to be downloaded via the bootloader, and the bootloader includes optimizations for download speed.
…ature - Adapt for pm test cmd - Update the calculate_sha256 api about signature - Fix the verify_firmware_signature api static issue
- Added BLE CoC SDK interface - Supports dynamic parameter changes for multi-advertisement of BLE - Update tfm and wifi libs
- Add hardware checksum port interface for lwIP. - Introduce hardware checksum registration mechanism to allow vendors to register hardware checksum functions for improved performance. The system will use software checksum automatically when no hardware function is registered. - Usage: 1. Enable CONFIG_NET_LWIP_HW_CHKSUM_PORT 2. Implement vendor-specific hardware checksum function with the following format: uint16_t vendor_chksum_func(const void *dataptr, int len) 3. Register the vendor function during initialization: lwip_register_hw_chksum(vendor_chksum_func)