Skip to content

Conversation

@seokhun-eom24
Copy link
Contributor

To prevent idle task errno from being set to EBADF during boot, replace dbg() with lldbg() in uart_register().
Because during uart_register stdout is not ready, so we have to use lldbg.

Registering log are printed like below.

up_initialize: [Reboot Reason] : 55
uart_register: Registering /dev/console
uart_register: Registering /dev/ttyS0
uart_register: Registering /dev/ttyS1
uart_register: Registering /dev/ttyS2
Logtask init ok!

Copy link
Member

@pcs1265 pcs1265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ewoodev ewoodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it mandatory logs during boot? if it's no, please use vlldbg.

The dbg is using stdout stream which is used /dev/console. the console register is needed replacing to lldbg
And, the UART Register is called before group_setupidlefiles which is getting fd of /dev/console`, so other registering also is needed lldbg.
It's correct changs. 👍👍👍

- Replace dbg with lldbg and llvdbg in uart_register
- Separate success and failure logs for driver registration

Signed-off-by: seokhun-eom <seokhun.eom@samsung.com>
@seokhun-eom24
Copy link
Contributor Author

is it mandatory logs during boot? if it's no, please use vlldbg.

The dbg is using stdout stream which is used /dev/console. the console register is needed replacing to lldbg And, the UART Register is called before group_setupidlefiles which is getting fd of /dev/console`, so other registering also is needed lldbg. It's correct changs. 👍👍👍

Right. Success log is not mandatory during boot.
I seperate log for success and fail case to use llvdbg and lldbg for each case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants