media: Sync Media Framework & Audio driver #7088
Conversation
sahilnara99
force-pushed
the
sync_branch
branch
3 times, most recently
from
45055b7 to
1303843
Compare
|
Commit message "media: Sync Media Framework & Audio driver" Please change it to explain the changes done. It helps in tracking the changes |
vibhor-m
left a comment
vibhor-m
left a comment
There was a problem hiding this comment.
Is it possible to split the big commit into smaller commits?
| @@ -0,0 +1,21 @@ | |||
| ########################################################################### | |||
| # | |||
| # Copyright 2025 Samsung Electronics All Rights Reserved. | |||
| # For a description of the syntax of this configuration file, | ||
| # see kconfig-language at https://www.kernel.org/doc/Documentation/kbuild/kconfig-language.txt | ||
| # | ||
| # This file is autogenerated, do not edit. |
There was a problem hiding this comment.
Is this line correct here, "# This file is autogenerated, do not edit."
This is not an auto generated file.
| config EXAMPLES_SOUNDPLAYER | ||
| bool "Sound Player" | ||
| default n | ||
| depends on HAVE_CXX |
There was a problem hiding this comment.
It also depends on controller application. disabling controller compilation will break
| auto& controller = PlayerController::getInstance(); | ||
|
|
||
| if (argc != 3 && argc != 4) { | ||
| printf("Usage: player <player_num> <command> [volume]\n"); |
There was a problem hiding this comment.
please expand usage to show input command options.
| #include <functional> | ||
| #include <map> | ||
| #include <media/FocusRequest.h> | ||
| //using FocusLossListener = std::function<void()>; |
There was a problem hiding this comment.
why is this line commented and moved to class FocusManager
| * @param[in] frames number of frames in buffers | ||
| * @endcond | ||
| */ | ||
| void mergeChannel(void *dataL, void *dataR, unsigned int frames); |
There was a problem hiding this comment.
This function is internal to media, we don't need to export this function outside media. Please check it should not be part of MediaUtils.h
framework/src/audio/SoundManager.cpp
Outdated
| @@ -0,0 +1,233 @@ | |||
| /**************************************************************************** | |||
| * | |||
| * Copyright 2024 Samsung Electronics All Rights Reserved. | |||
sahilnara99
force-pushed
the
sync_branch
branch
from
1303843 to
7978628
Compare
Co-Authored-By: Aayush Verma <aa.verma@samsung.com>
sahilnara99
force-pushed
the
sync_branch
branch
from
7978628 to
1ba67c1
Compare
2 participants
media: Sync Media Framework & Audio driver
Tested below apps:
1.) wakerec app: Keyword Detection, record and playback same recorded audio.
2.) sound player app: Play the file on a specific path
3.) Sound Player Mixer Testing: Validated the audio mixer functionality, ensuring proper mixing of multiple audio streams with correct volume control, resume, stop, mute, unmute, play the specific player.