Skip to content

[SYNPY-1714] Fix Issues with Failing Tests #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaymedina merged 6 commits into from
Dec 3, 2025
Merged

[SYNPY-1714] Fix Issues with Failing Tests #1287

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ae63c81
always log warning
SageGJ Dec 2, 2025
5a699ac
check assert called with
SageGJ Dec 2, 2025
6d5f04e
patch object on class instance
SageGJ Dec 2, 2025
91d88c6
Revert "always log warning"
SageGJ Dec 2, 2025
3de0079
update patch target
SageGJ Dec 2, 2025
f730271
re-add erroneously removed line
SageGJ Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/unit/synapseclient/unit_test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ def init_syn(self, syn: Synapse) -> None:
self.syn.credentials = SynapseAuthTokenCredentials(token="abc", username="def")

def test_check_entity_restrictions_no_unmet_restriction(self) -> None:
with patch("logging.Logger.warning") as mocked_warn:
with patch.object(self.syn.logger, "warning") as mocked_warn:
bundle = {
"entity": {
"id": "syn123",
Expand All @@ -1189,7 +1189,7 @@ def test_check_entity_restrictions_no_unmet_restriction(self) -> None:
def test_check_entity_restrictions_unmet_restriction_entity_file_with_download_file_is_true(
self,
) -> None:
with patch("logging.Logger.warning") as mocked_warn:
with patch.object(self.syn.logger, "warning") as mocked_warn:
bundle = {
"entity": {
"id": "syn123",
Expand Down
Loading