fix: update playtime command to handle asynchronous player retrieval #135
Conversation
TheBjoRedCraft
temporarily deployed
to
production
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR updates the playtime command to properly handle asynchronous player retrieval by changing the player argument type from OfflineCloudPlayer? to Deferred<OfflineCloudPlayer?>, fixing issue #117. The change aligns with how the offlineCloudPlayerArgument actually returns deferred values that must be awaited in a coroutine context.
Key Changes
- Updated player argument type to
Deferred<OfflineCloudPlayer?>with proper async handling usingawait() - Added coroutine scope with
plugin.launchto handle the deferred player retrieval - Included translation consistency fix changing "Total" to "Gesamt" to match German localization
| plugin.launch { | ||
| player.await()?.let { sendPlaytime(sender, it) } | ||
| } |
There was a problem hiding this comment.
The sendPlaytime function already calls plugin.launch internally (line 35), so wrapping this call in another plugin.launch creates unnecessary nested coroutine scopes.
Consider removing the outer plugin.launch and calling sendPlaytime directly within a suspend function, similar to how LastSeenCommand handles this pattern:
anyExecutor { sender, args ->
val player: Deferred<OfflineCloudPlayer?> by args
plugin.launch {
val awaited = player.await() ?: return@launch
sendPlaytime(sender, awaited)
}
}Or refactor sendPlaytime to be a regular function that doesn't launch its own coroutine, allowing the caller to control the coroutine scope.
Qodana for JVM535 new problems were found
☁️ View the detailed Qodana report Contact Qodana teamContact us at qodana-support@jetbrains.com
|
fixes #117