Skip to content

Conversation

@TheBjoRedCraft
Copy link
Member

No description provided.

@TheBjoRedCraft TheBjoRedCraft self-assigned this Dec 30, 2025
Copilot AI review requested due to automatic review settings December 30, 2025 14:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for core modules in the Gradle plugin configuration, mirroring the existing cloud module pattern. The implementation allows projects to declare dependencies on platform-specific core modules (Common, Paper, Velocity) through the Gradle plugin extension.

Key changes:

  • Introduced SurfCoreModules enum to define available core module types
  • Extended plugin extensions with coreModule property and helper methods (withCoreCommon, withCorePaper, withCoreVelocity)
  • Updated plugin dependency registration to include core modules in Paper and Velocity plugin descriptors

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SurfCoreModules.kt New enum defining the three core module types (COMMON, PAPER, VELOCITY) with their Maven artifact names
CommonSurfExtension.kt Added coreModule property to hold the selected core module; minor formatting improvement to publishingUrl property
CoreSurfExtension.kt Added three convenience methods (withCoreCommon, withCorePaper, withCoreVelocity) to configure core module dependencies
CommonSurfPlugin.kt Added dependency configuration logic to include the selected core module as a compile-only dependency
PaperPluginSurfPlugin.kt Registered surf-core-paper as a required server dependency when core module is present
VelocityPluginFile.kt Registered surf-core-velocity as a required plugin dependency when core module is present
build.gradle.kts Incremented plugin version from 1.6.4 to 1.6.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TheBjoRedCraft TheBjoRedCraft changed the title feat: add support for core modules in Gradle plugin configuration feat: add support for surf-core api integration Dec 30, 2025
@twisti-dev twisti-dev merged commit be488d5 into version/1.21.11 Dec 30, 2025
3 of 4 checks passed
@twisti-dev twisti-dev deleted the feat/add-surf-core branch December 30, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants