Fix Groom issues #2467, #2466 #2468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…room run The cache was being cleared after set_display_mode() was called in handle_groom_complete(). However, set_display_mode() emits an update_view_mode() signal which triggers update_display(), causing mesh lookups to hit the stale cache before it was cleared. This resulted in an alternating pattern where groomed meshes would only reload on every other groom run. Move handle_clear_cache() to before set_display_mode() so the cache is cleared before any display updates are triggered.
The issue is that we have to remove the existing normals first or the filter will skip creation if normals already exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of groom/mesh issues as well as updates the vtkWindowedSincPolyDataFilter basic options and parameters.